A coupla days ago I bleated about array_map [having] a dumb implementation. I had what I thought was an obvious application for array_map in PHP, but it couldn't really accommodate me due to array_map not exposing the array's keys to the callback, and then messing up the keys in the mapped array if one passes array_map more than one array to process.
I needed to remap this:
[
"2008-11-08" => "Jacinda",
"1990-10-27" => "Bill",
"2014-09-20" => "James",
"1979-05-24" => "Winston"
]
To this:
array(4) {
'2008-11-08' =>
class IndexedPerson#3 (2) {
public $date =>
string(10) "2008-11-08"
public $name =>
string(7) "Jacinda"
}
'1990-10-27' =>
class IndexedPerson#4 (2) {
public $date =>
string(10) "1990-10-27"
public $name =>
string(4) "Bill"
}
'2014-09-20' =>
class IndexedPerson#5 (2) {
public $date =>
string(10) "2014-09-20"
public $name =>
string(5) "James"
}
'1979-05-24' =>
class IndexedPerson#6 (2) {
public $date =>
string(10) "1979-05-24"
public $name =>
string(7) "Winston"
}
}
Note how the remapped object also contains the original key value. That was the sticking point. Go read the article for more detail and more whining.
OK so my expectations of PHP's array higher order functions are based on my experience with JS's and CFML's equivalents. Both of which receive the key as well as the value in all callbacks. I decided to see how other languages achieve the same end, and I'll pop the codee in here for shits 'n' giggles.
CFML
Given most of my history is as a CFML dev, that one was easy.peopleData = ["2008-11-08" = "Jacinda", "1990-10-27" = "Bill", "2014-09-20" = "James", "1979-05-24" = "Winston"]
people = peopleData.map((date, name) => new IndexedPerson(date, name))
people.each((date, person) => echo("#date# => #person#<br>"))
Oh, this presupposes the IndexedPerson component. Due to a shortcoming of how CFML works, components must be declared in a file of their own:
component {
function init(date, name) {
this.date = date
this.name = name
}
string function _toString() {
return "{date:#this.date#; name: #this.name#}"
}
}
But the key bit is the mapping operation:
people = peopleData.map((date, name) => new IndexedPerson(date, name))
Couldn't be simpler (NB: this is Lucee's CFML implementation, not ColdFusion's which does not yet support arrow functions).
The output is:
2008-11-08 => {date:2008-11-08; name: Jacinda}
1990-10-27 => {date:1990-10-27; name: Bill}
2014-09-20 => {date:2014-09-20; name: James}
1979-05-24 => {date:1979-05-24; name: Winston}
JS
The next language I turned to was JS as that's the I'm next most familiar with. One thing that hadn't occurred to me is that whilst JS's Array implementation has a map method, we need to use an object here as the keys are values not indexes. And whilst I knew Objects didn't have a map method, I didn't know what the equivalent might be.Well it turns out that there's no real option to use a map here, so I needed to do a reduce on the object's entries, Still: it's pretty terse and obvious:
class IndexedPerson {
constructor(date, name) {
this.date = date
this.name = name
}
}
let peopleData = {"2008-11-08": "Jacinda", "1990-10-27": "Bill", "2014-09-20": "James", "1979-05-24": "Winston"}
let people = Object.entries(peopleData).reduce(function (people, personData) {
people.set(personData[0], new IndexedPerson(personData[0], personData[1]))
return people
}, new Map())
console.log(people)
This returns what we want:
Map {
'2008-11-08' => IndexedPerson { date: '2008-11-08', name: 'Jacinda' },
'1990-10-27' => IndexedPerson { date: '1990-10-27', name: 'Bill' },
'2014-09-20' => IndexedPerson { date: '2014-09-20', name: 'James' },
'1979-05-24' => IndexedPerson { date: '1979-05-24', name: 'Winston' } }
TBH I think this is a misuse of an object to contain basically an associative array / struct, but so be it. It's the closest analogy to the PHP requirement. I was able to at least return it as a Map, which I think is better. I tried to have the incoming personData as a map, but the Map prototype's equivalent of entries() used above is unhelpful in that it returns an Iterator, and the prototype for Iterator is a bit spartan.
I think it's slightly clumsy I need to access the entries value via array notation instead of some sort of name, but this is minor.
As with all my code, I welcome people showing me how I should actually be doing this. Post a comment. I'm looking at you Ryan Guill ;-)
Java
Next up was Java. Holy fuck what a morass of boilterplate nonsense I needed to perform this simple operation in Java. Deep breath...import java.util.HashMap;
import java.util.Map;
import java.util.stream.Collectors;
class IndexedPerson {
String date;
String name;
public IndexedPerson(String date, String name) {
this.date = date;
this.name = name;
}
public String toString(){
return String.format("{date: %s, name: %s}", this.date, this.name);
}
}
class Collect {
public static void main(String[] args) {
HashMap<String,String> peopleData = loadData();
HashMap<String, IndexedPerson> people = mapToPeople(peopleData);
dumpIdents(people);
}
private static HashMap<String,String> loadData(){
HashMap<String,String> peopleData = new HashMap<String,String>();
peopleData.put("2008-11-08", "Jacinda");
peopleData.put("1990-10-27", "Bill");
peopleData.put("2014-09-20", "James");
peopleData.put("1979-05-24", "Winston");
return peopleData;
}
private static HashMap<String,IndexedPerson> mapToPeople(HashMap<String,String> peopleData) {
HashMap<String, IndexedPerson> people = (HashMap<String, IndexedPerson>) peopleData.entrySet().stream()
.collect(Collectors.toMap(
e -> e.getKey(),
e -> new IndexedPerson(e.getKey(), e.getValue())
));
return people;
}
private static void dumpIdents(HashMap<String,IndexedPerson> people) {
for (Map.Entry<String, IndexedPerson> entry : people.entrySet()) {
System.out.println(String.format("%s => %s", entry.getKey(), entry.getValue()));
}
}
}
Result:
1979-05-24 => {date: 1979-05-24, name: Winston}
2014-09-20 => {date: 2014-09-20, name: James}
1990-10-27 => {date: 1990-10-27, name: Bill}
2008-11-08 => {date: 2008-11-08, name: Jacinda}
Most of that lot seems to be just messing around telling Java what types everything are. Bleah.
The interesting bit - my grasp of which is tenuous - is the Collectors.toMap. I have to admit I derived that from reading various Stack Overflow articles. But I got it working, and I know the general approach now, so that's good.
Too much code for such a simple thing though, eh?
Groovy
Groovy is my antidote to Java. Groovy makes this shit easy:class IndexedPerson {
String date
String name
IndexedPerson(String date, String name) {
this.date = date;
this.name = name;
}
String toString(){
String.format("date: %s, name: %s", this.date, this.name)
}
}
peopleData = ["2008-11-08": "Jacinda", "1990-10-27": "Bill", "2014-09-20": "James", "1979-05-24": "Winston"]
people = peopleData.collectEntries {date, name -> [date, new IndexedPerson(date, name)]}
people.each {date, person -> println String.format("%s => {%s}", date, person)}
Bear in mind that most of that is getting the class defined, and the output. The bit that does the mapping is just the one line in the middle. That's more like it.
Again, I don't know much about Groovy… I had to RTFM to find out how to do the collectEntries bit, but it was easy to find and easy to understand.
I really wish I had a job doing Groovy.
Oh yeah, for the sake of completeness, the output was thus:
2008-11-08 => {date: 2008-11-08, name: Jacinda}
1990-10-27 => {date: 1990-10-27, name: Bill}
2014-09-20 => {date: 2014-09-20, name: James}
1979-05-24 => {date: 1979-05-24, name: Winston}
Ruby
Ruby's version was pretty simple too as it turns out. No surprise there as Ruby's all about higher order functions and applying blocks to collections and stuff like that.class IndexedPerson
def initialize(date, name)
@date = date
@name = name
end
def inspect
"{date:#{@date}; name: #{@name}}\n"
end
end
peopleData = {"2008-11-08" => "Jacinda", "1990-10-27" => "Bill", "2014-09-20" => "James", "1979-05-24" => "Winston"}
people = peopleData.merge(peopleData) do |date, name|
IndexedPerson.new(date, name)
end
puts people
Predictable output:
{"2008-11-08"=>{date:2008-11-08; name: Jacinda}
, "1990-10-27"=>{date:1990-10-27; name: Bill}
, "2014-09-20"=>{date:2014-09-20; name: James}
, "1979-05-24"=>{date:1979-05-24; name: Winston}
}
I wasn't too sure about all that block nonsense when I first started looking at Ruby, but I quite like it now. It's easy to read.
Python
My Python skills don't extend much beyond printing G'day World on the screen, but it was surprisingly easy to google-up how to do this. And I finally got to see what Python folk are on about with this "comprehensions" stuff, which I think is quite cool.class IndexedPerson:
def __init__(self, date, name):
self.date = date
self.name = name
def __repr__(self):
return "{{date: {date}, name: {name}}}".format(date=self.date, name=self.name)
people_data = {"2008-11-08": "Jacinda", "1990-10-27": "Bill", "2014-09-20": "James", "1979-05-24": "Winston"}
people = {date: IndexedPerson(date, name) for (date, name) in people_data.items()}
print("\n".join(['%s => %s' % (date, person) for (date, person) in people.items()]))
And now that I am all about Clean Code, I kinda get the "whitespace as indentation" thing too. It's clear enough if yer code is clean in the first place.
The output of this is identical to the Groovy one.
Only one more then I'll stop.
Clojure
I can only barely do G'day World in Clojure, so this took me a while to work out. I also find the Clojure docs to be pretty impentrable. I'm sure they're great if one already knows what one is doing, but I found them pretty inaccessible from the perspective of a n00b. It's like if the PHP docs were solely the user-added stuff at the bottom of each docs page. Most blog articles I saw about Clojure were pretty much just direct regurgitation of the docs, without much value-add, if I'm to be honest.(defrecord IndexedPerson [date name])
(def people-data (array-map "2008-11-08" "Jacinda" "1990-10-27" "Bill" "2014-09-20" "James" "1979-05-24" "Winston"))
(def people
(reduce-kv
(fn [people date name] (conj people (array-map date (IndexedPerson. date name))))
(array-map)
people-data))
(print people)
The other thing with Clojure for me is that the code is so alien-looking to me that I can't work out how to indent stuff to make the code clearer. All the examples I've seen don't seem very clear, and the indentation doesn't help either, I think. I guess with more practise it would come to me.
It seems pretty powerful though, cos there's mot much code there to achieve the desired end-goal.
Output for this one:
{2008-11-08 #user.IndexedPerson{:date 2008-11-08, :name Jacinda},
1990-10-27 #user.IndexedPerson{:date 1990-10-27, :name Bill},
2014-09-20 #user.IndexedPerson{:date 2014-09-20, :name James},
1979-05-24 #user.IndexedPerson{:date 1979-05-24, :name Winston}}
Summary
This was actually a very interesting exercise for me, and I learned stuff about all the languages concerned. Even PHP and CFML.I twitterised a comment regarding how pleasing I found each solution:
In order of ease of use and how pleasing the solution seemed:— Adam Cameron (@adam_cameron) November 25, 2017
1 Python
2 Ruby
3 Groovy
4 CFML
5 JS
6 PHP
7 Java
This was before I did the Clojure one, and I'd slot that in afer CFML and before JS, making the list:
- Python
- Ruby
- Groovy
- CFML
- Clojure
- JS
- PHP
- Java
Python's code looks nice and it was easy to find out what to do. Same with Ruby, just not quite so much. And, really same with Groovy. I could order those three any way. I think Python tips the scales slightly with the comprehensions.
CFML came out suprisingly well in this, as it's a bloody easy exercise to achieve with it.
Clojure's fine, just a pain in the arse to understand what's going on, and the code looks a mess to me. But it does a lot in little space.
JS was disappointing because it wasn't nearly so easy as I expected it to be.
PHP is a mess.
And - fuck me - Java. Jesus.
My occasional reader Barry O'Sullivan volunteered some input the other day:
Cool. If you'd like a Golang example just let me know. Be fun to collaborate.— Barry O Sullivan (@barryosull) November 26, 2017
Hopefully he's still up for this, and I'll add it to the list so we can have a look at that code too.
Like I said before, if you know a better or more interesting way to do this in any of the languages above, or any other languages, make a comment and post a link to a Gist (just don't put the code inline in the comment please; it will not render at all well).
I might have another one of these exercises to do soon with another puzzle a friend of mine had to recently endure in a job-interview-related coding test. We'll see.
Righto.
--
Adam
